Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/cordova/apple/macos): force rendering of add server button #1973

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Apr 15, 2024

Note that the server view doesn't render on debug mode because of a Lit issue

Screen.Recording.2024-04-15.at.2.53.49.PM.mov

@daniellacosse daniellacosse added the needs test Pull requests that require tests label Apr 15, 2024
@daniellacosse daniellacosse removed the needs test Pull requests that require tests label Apr 15, 2024
@daniellacosse daniellacosse marked this pull request as ready for review April 15, 2024 18:58
@daniellacosse daniellacosse requested a review from a team as a code owner April 15, 2024 18:58
@sbruens
Copy link
Contributor

sbruens commented Apr 15, 2024

Ugh I thought I fixed that server rendering issue in debug mode when I upgraded the list to Lit. Something must have changed again?

@daniellacosse daniellacosse changed the title fix(client/cordova/macos): force rendering of add server button fix(client/cordova/apple/macos): force rendering of add server button Apr 15, 2024
@daniellacosse daniellacosse linked an issue Apr 15, 2024 that may be closed by this pull request
@daniellacosse daniellacosse merged commit f00a94c into master Apr 15, 2024
18 of 19 checks passed
@daniellacosse daniellacosse deleted the daniellacosse/macos-rendering-fix branch April 15, 2024 19:22
@khlebobul
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Displaying the Add Server button on macOS
3 participants